test-tls-check-server-identity var->const, assert, string template#9986
Closed
koxauvin wants to merge 3 commits intonodejs:masterfrom
koxauvin:test-tls-check-server-identity
Closed
test-tls-check-server-identity var->const, assert, string template#9986koxauvin wants to merge 3 commits intonodejs:masterfrom koxauvin:test-tls-check-server-identity
koxauvin wants to merge 3 commits intonodejs:masterfrom
koxauvin:test-tls-check-server-identity
Conversation
Contributor
|
Please see the commit message guidelines here. |
imyller
added
the
code-and-learn
cjihrig
approved these changes
Dec 5, 2016
jasnell
requested changes
Dec 5, 2016
Member
There was a problem hiding this comment.
Please avoid multi-line template literals, especially given that the additional whitespace will be included in the string.
`Test# ${i} failed: ${util.inspect(test)} \n` +
`${test.error} != ${(err && err.reason)}`);
Member
There was a problem hiding this comment.
please move the assert and util requires after the hasCrypto check
Contributor
Author
There was a problem hiding this comment.
I tried removing the block
if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
but module common is not used "error 'common' is assigned a value but never used no-unused-vars".
Then when I remove the require for common I get "error Mandatory module "common" must be loaded required-modules"
The util requires in used in the string template, can't remove that.
Member
There was a problem hiding this comment.
@koxauvin Please don't remove the hasCrypto check. It is needed for this test. But please move the assignments to assert and util to be after that block.
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output.
Converted multi-line string template literals to string concatentation.
Converted multi-line string template literals to string concatentation.
Member
Member
jasnell
approved these changes
Dec 24, 2016
Member
|
Lone CI failure is a Jenkins/build issue and unrelated to the changes here. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 24, 2016
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: nodejs#9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in b00f8ad. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output. PR-URL: #9986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Changed var to const, assert.equal to assert.strictEqual, and used a template string for error output.