test: updating test file to use strictEqual#9985
Closed
ashtonian wants to merge 1 commit intonodejs:masterfrom
ashtonian:node-update-es6-test-fix1
Closed
test: updating test file to use strictEqual#9985ashtonian wants to merge 1 commit intonodejs:masterfrom ashtonian:node-update-es6-test-fix1
ashtonian wants to merge 1 commit intonodejs:masterfrom
ashtonian:node-update-es6-test-fix1
Conversation
mscdex
added
the
child_process
imyller
added
the
code-and-learn
Contributor
|
nit: there is a typo in the commit message |
ashtonian
changed the title
updating test file to use assert.strictEqual() instead of assert.equal()
Contributor
Author
|
Fixed. |
jasnell
approved these changes
Dec 5, 2016
addaleax
approved these changes
Dec 8, 2016
Member
Member
|
These changes have already landed via another pull request. Looks like I might have given this task out twice. Sorry for my error! Glad to see your other pull request (#10080) landed! I'm going to close this one. Again, sorry about my mistake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
updating test file to use assert.strictEqual() instead of
assert.equal()