test: minor changes to test-crypto-padding.js#9971
Closed
likhter wants to merge 1 commit intonodejs:masterfrom
Closed
test: minor changes to test-crypto-padding.js#9971likhter wants to merge 1 commit intonodejs:masterfrom
likhter wants to merge 1 commit intonodejs:masterfrom
Conversation
imyller
added
the
code-and-learn
princejwesley
approved these changes
Dec 1, 2016
Contributor
princejwesley
left a comment
princejwesley
left a comment
There was a problem hiding this comment.
Instead of minor changes to ..., use refactor ... in commit message
Member
Member
|
Thanks for the pull request! |
Member
|
(The lint error is that there are two lines longer than 80 characters. If you want to run the JavaScript linter without running all the tests, you can do |
Member
|
Actually, now there's a merge conflict, so I'll fix the lint issue while resolving that... |
Replaced all `var` with `const` or `let`. Changed `assert.equal` to `assert.strictEqual`. Added error message checking for every .throw call.
Trott
force-pushed
the
test-crypto-padding-fixes
branch
from
cbb1530 to
d8b3b55
Compare
Member
addaleax
approved these changes
Dec 5, 2016
Contributor
|
Landed in 52545bb. Thanks! |
cjihrig
pushed a commit
that referenced
this pull request
Dec 5, 2016
- Replaced var with const and let. - Replaced assert.equal() with assert.strictEqual(). - Added error message checking for assert.throws(). PR-URL: #9971 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
- Replaced var with const and let. - Replaced assert.equal() with assert.strictEqual(). - Added error message checking for assert.throws(). PR-URL: #9971 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
- Replaced var with const and let. - Replaced assert.equal() with assert.strictEqual(). - Added error message checking for assert.throws(). PR-URL: nodejs#9971 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
- Replaced var with const and let. - Replaced assert.equal() with assert.strictEqual(). - Added error message checking for assert.throws(). PR-URL: nodejs#9971 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- Replaced var with const and let. - Replaced assert.equal() with assert.strictEqual(). - Added error message checking for assert.throws(). PR-URL: #9971 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Replaced all
varwithconstorlet.Changed
assert.equaltoassert.strictEqual.Added error message checking to every
.throwcall.