Closed
Conversation
imyller
added
the
code-and-learn
Contributor
|
The commit message should start with |
Contributor
princejwesley
left a comment
princejwesley
left a comment
There was a problem hiding this comment.
- Merge commits as single commit
- Commit message is too long, follow commit message guideline
rgoodwin
force-pushed
the
update-tls-client-test
branch
from
4e6c8c5 to
9b9161c
Compare
Author
|
@mscdex @princejwesley cleaned up commit message and squashed commits. Please let me know if there is anything else. |
Contributor
|
The prefix should be |
Replace variable defs using var with more up to date const/let. Updated tests to use strict equality to ensure type and value comparision tests: wrap callback functions in common.mustCall to ensure single execution
rgoodwin
force-pushed
the
update-tls-client-test
branch
from
9b9161c to
d1e235a
Compare
Contributor
|
@rgoodwin gj, commit message updated. |
Author
|
@mscdex Fixed, thanks for catching that. |
addaleax
approved these changes
Dec 2, 2016
Member
Author
|
@addaleax Can you recommend what I should do now. I'm new to this build and it looks like it has a lot of target OS/hardware combos. It looks like it failed on ARM etc... because of a timeout. Not sure how I would debug on those platforms. I'm on OSX and on that I followed the contribution guide and ran Or are the timeouts part of long test cycles and I somehow need to re-run the build etc..? Thanks |
Member
|
@rgoodwin These timeouts are not related to the test file you are changing, so we should be good here :) |
jasnell
approved these changes
Dec 5, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 5, 2016
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: #9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in c142e27. Thank you for the PR and for participating in the code-and-learn! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: #9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: nodejs#9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: nodejs#9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* Replace variable defs using var with more up to date const/let. * Updated tests to use strict equality to ensure type and value comparision * wrap callback functions in common.mustCall to ensure single execution PR-URL: #9968 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tests
Description of change
Update tls test with
const/letfor definition of variables (instead of using var).common.mustCallto avoid repeated calls