test: refactor test-domain-multi#9963
Closed
WesTyler wants to merge 1 commit intonodejs:masterfrom
xogroup:test_domain_multi
Closed
test: refactor test-domain-multi#9963WesTyler wants to merge 1 commit intonodejs:masterfrom xogroup:test_domain_multi
WesTyler wants to merge 1 commit intonodejs:masterfrom
xogroup:test_domain_multi
Conversation
imyller
added
the
code-and-learn
mscdex
added
domain
cjihrig
requested changes
Dec 5, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
The commit message looks like it references the wrong test.
* assert.equal() -> assert.strictEqual()
Contributor
Author
|
@cjihrig you're right. I amended the commit message with the correct test name. Thanks for catching that. |
cjihrig
approved these changes
Dec 5, 2016
addaleax
approved these changes
Dec 5, 2016
jasnell
approved these changes
Dec 5, 2016
evanlucas
approved these changes
Dec 6, 2016
Contributor
|
Landed in c26419b. Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Dec 6, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: #9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Contributor
Author
|
Thanks! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: #9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: nodejs#9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: nodejs#9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: #9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: #9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Replace assert.equal() with assert.strictEqual(). PR-URL: #9963 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This was referenced Jul 1, 2023
This was referenced Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change