test: Change equal to strictEqual and pass delay to setTimeout#9938
Closed
qualquervalor2 wants to merge 3 commits intonodejs:masterfrom
Closed
test: Change equal to strictEqual and pass delay to setTimeout#9938qualquervalor2 wants to merge 3 commits intonodejs:masterfrom
qualquervalor2 wants to merge 3 commits intonodejs:masterfrom
Conversation
imyller
added
the
code-and-learn
qualquervalor2
force-pushed
the
tweakDomainExitTest
branch
from
cb81a4e to
3c78fb5
Compare
Fishrock123
suggested changes
Dec 2, 2016
| disposalFailed = true; | ||
| process.exit(1); | ||
| }); | ||
| }, 0); |
Contributor
There was a problem hiding this comment.
@qualquervalor2 Could you check if this works with setImmediate() instead of setTimeout()?
If it doesn't work, could you change the 0 to a 1? The 0 becomes a 1 under the hood so it would be better to be explicit up front. :)
Author
There was a problem hiding this comment.
setImediate() did not work. Updated the PR to use 1.
jasnell
reviewed
Dec 5, 2016
| disposalFailed = true; | ||
| process.exit(1); | ||
| }); | ||
| }, 1); |
Member
There was a problem hiding this comment.
This can likely be changed to use common.mustCall() ... for instance:
setTimeout(common.mustCall(() => {}, 0), 1);
jasnell
approved these changes
Dec 6, 2016
Member
lpinca
approved these changes
Dec 6, 2016
Member
|
@Fishrock123 ... are you good with this now? |
Fishrock123
approved these changes
Dec 7, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 7, 2016
change equal to strictEqual, fix setTimeout PR-URL: nodejs#9938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Member
|
Landed in 25dfb8e |
Member
|
Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
change equal to strictEqual, fix setTimeout PR-URL: #9938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
change equal to strictEqual, fix setTimeout PR-URL: nodejs#9938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
change equal to strictEqual, fix setTimeout PR-URL: #9938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
change equal to strictEqual, fix setTimeout PR-URL: #9938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
change equal to strictEqual, fix setTimeout PR-URL: #9938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change