test: setTimeout must have at least 2 arguments + assert.strictEqual instead of equal#9933
Closed
junior wants to merge 0 commit intonodejs:masterfrom
Closed
test: setTimeout must have at least 2 arguments + assert.strictEqual instead of equal#9933junior wants to merge 0 commit intonodejs:masterfrom
junior wants to merge 0 commit intonodejs:masterfrom
Conversation
Member
|
@junior May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
Contributor
Author
|
commit message changed to match the guidelines |
Contributor
Author
|
comment template restored |
Member
|
@junior PR info looks good but git commit message is still |
Contributor
Author
|
reverting wrong commit and sending a new PR, to make it right. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
x make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
x commit message follows commit guidelines
Affected core subsystem(s)
test/parallel
Description of change
setTimeout with only 1 argument, should have 2 at least. Include 1 for the Delay.
and
assert.strictEqual() instead of assert.equal()