changes var to let & const as appropriate#9920
Closed
markmachine wants to merge 3 commits intonodejs:masterfrom
Closed
changes var to let & const as appropriate#9920markmachine wants to merge 3 commits intonodejs:masterfrom
markmachine wants to merge 3 commits intonodejs:masterfrom
Conversation
change tests to use assert.strictEqual vs assert.equal
cjihrig
approved these changes
Dec 1, 2016
mscdex
added
child_process
princejwesley
approved these changes
Dec 1, 2016
Contributor
princejwesley
left a comment
princejwesley
left a comment
There was a problem hiding this comment.
Please change the commit msg with test: prefix
imyller
added
the
code-and-learn
Member
|
@markmachine May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
* references closed nodejs#2446 * updates broken documentation link * fixes copy based on comments from @sam-github
imyller
reviewed
Dec 1, 2016
doc/api/os.md
Outdated
|
|
||
| * Android: `"android"` | ||
| * Windows/Cygwin: `"win32"` | ||
| * Mac OS X: `"darwin"` |
Member
There was a problem hiding this comment.
I think the proper branding here is macOS
This reverts commit a0070b5.
Author
|
@imyller my apologies, i meant to make a separate PR. I will fix the problems and start again. Thanks for your help. |
lpinca
approved these changes
Dec 5, 2016
Member
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 6, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: nodejs#9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in b074ae2. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: #9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: nodejs#9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: nodejs#9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: #9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: #9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var -> const * assert.equal() -> assert.strictEqual() PR-URL: #9920 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
change tests to use assert.strictEqual vs assert.equal