test: var -> let/const, .equal -> .strictEqual#9913
Closed
shiya wants to merge 1 commit intonodejs:masterfrom
shiya:update
Closed
test: var -> let/const, .equal -> .strictEqual#9913shiya wants to merge 1 commit intonodejs:masterfrom shiya:update
shiya wants to merge 1 commit intonodejs:masterfrom
shiya:update
Conversation
var -> let/const .equal -> .strictEqual
princejwesley
approved these changes
Dec 1, 2016
imyller
added
the
code-and-learn
Member
addaleax
approved these changes
Dec 2, 2016
cjihrig
approved these changes
Dec 3, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Code change LGTM. The CI is loading really slowly right now, so I didn't check the results.
Member
|
CI got canceled yesterday before completing. Happened when I started a whole bunch of CI jobs for Code & Learn and someone probably thought the backup just meant they were hung and never going to finish. Let's try again. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 3, 2016
var -> let/const .equal -> .strictEqual PR-URL: nodejs#9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 3401cad |
Member
|
🎉 Thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
var -> let/const .equal -> .strictEqual PR-URL: #9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
var -> let/const .equal -> .strictEqual PR-URL: nodejs#9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
var -> let/const .equal -> .strictEqual PR-URL: nodejs#9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
var -> let/const .equal -> .strictEqual PR-URL: #9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
var -> let/const .equal -> .strictEqual PR-URL: #9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
var -> let/const .equal -> .strictEqual PR-URL: #9913 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
var -> let/const
.equal -> .strictEqual