test: fix flaky test-net-GH-5504#9461
Merged
santigimeno merged 1 commit intonodejs:masterfrom Nov 6, 2016
Merged
Conversation
bnoordhuis
approved these changes
Nov 4, 2016
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but it sure raises the question of why removing the watchdog timer would fix the flakiness.
Member
Author
|
Could it be that if the timer fires and the server and/or client processes are still alive, killing them doesn't cause the process to exit immediately so the |
cjihrig
approved these changes
Nov 4, 2016
Member
Author
2 tasks
targos
approved these changes
Nov 5, 2016
Member
|
Just a note that I think a |
The test is failing on `SmartOS` quite often. Removing the timeout seems to fix it. Fixes: nodejs#8930 PR-URL: nodejs#9461 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
santigimeno
force-pushed
the
remove_timeout
branch
from
4b43343 to
f8f67d2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
The test is failing on
SmartOSquite often. Removing the timeout seemsto fix it.
It's an alternate fix to #9444