build: add MAKEFLAGS="-j1" to node-gyp by danbev · Pull Request #9450 · nodejs/node

danbev · 2016-11-03T19:52:02Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

Description of change

Currently, when building the addons the following warning is displayed:

make[2]: warning: jobserver unavailable: using -j1.  Add `+' to parent
make rule.

Adding the MAKEFLAGS="-j1" to avoid the warning.

Also updated the log message to say that it is building the addon and
not running the test as I think that is more accurate.

danbev · 2016-11-03T19:52:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4773/

addaleax

LGTM

/cc @bnoordhuis

bnoordhuis

The first line of the commit log is slightly too long.

bnoordhuis · 2016-11-03T22:10:17Z

Makefile

env MAKEFLAGS="-j1" ...? I believe what you have now is a bash-ism, not a posix-ism.

Ah indeed, I'll correct this. Thanks

danbev · 2016-11-04T06:25:13Z

The first line of the commit log is slightly too long.

Sorry, for some reason I though 52 characters was the limit but of course it is 50 (the 2 is for in other lines and then it's 72). Thanks

danbev · 2016-11-04T06:25:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4780/

thefourtheye · 2016-11-04T12:30:27Z

Makefile

I was thinking about silencing this in the other commit and it landed before I got a chance to get back to it. Can we do it in this? I am okay without that as well.

Can we do it in this?

Absolutely, no problems.

Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate.

danbev · 2016-11-05T20:15:36Z

Rebased and new CI: https://ci.nodejs.org/job/node-test-pull-request/4789/

danbev · 2016-11-06T19:24:19Z

CI failure does not seem related to this change:

not ok 236 parallel/test-debugger-util-regression
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: the program should not hang
#     at Object.exports.fail (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common.js:443:10)
#     at Timeout.fail [as _onTimeout] (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-debugger-util-regression.js:23:10)
#     at ontimeout (timers.js:365:14)
#     at tryOnTimeout (timers.js:237:5)
#     at Timer.listOnTimeout (timers.js:207:5)

If there are no objections I'll merge this tomorrow.

Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: nodejs#9450 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

danbev · 2016-11-07T12:42:40Z

Landed in: a504516

Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2016-11-22T07:51:48Z

should this be backported?

Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: nodejs#9450 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 3, 2016

addaleax approved these changes Nov 3, 2016

View reviewed changes

bnoordhuis requested changes Nov 3, 2016

View reviewed changes

danbev force-pushed the supress-addons-build-warn branch from ec33fca to 772be0f Compare November 4, 2016 06:23

danbev changed the title ~~build: add MAKEFLAGS="-j1" to node-gyp to avoid warn~~ build: add MAKEFLAGS="-j1" to node-gyp Nov 4, 2016

bnoordhuis approved these changes Nov 4, 2016

View reviewed changes

thefourtheye approved these changes Nov 4, 2016

View reviewed changes

cjihrig approved these changes Nov 4, 2016

View reviewed changes

danbev added 3 commits November 5, 2016 21:03

use the shell env command to set MAKEFLAGS

327cd52

supress echoing of for loop

fb4eafd

danbev force-pushed the supress-addons-build-warn branch from ce36c39 to fb4eafd Compare November 5, 2016 20:14

danbev closed this Nov 7, 2016

evanlucas mentioned this pull request Nov 7, 2016

v7.1.0 proposal - 2016-11-08 #9438

Merged

MylesBorins added lts-watch-v4.x labels Nov 22, 2016

thefourtheye mentioned this pull request Dec 21, 2016

v4.x backport silent logs in addons tests #10366

Closed

2 tasks

MylesBorins added the dont-land-on-v4.x label Dec 21, 2016

MylesBorins added land-on-v6.x and removed lts-watch-v4.x labels Dec 21, 2016

This was referenced Dec 21, 2016

V6.9.3 proposal #10394

Merged

V4.7.1 proposal #10395

Merged

danbev deleted the supress-addons-build-warn branch January 17, 2017 07:24

Uh oh!

Conversation

danbev commented Nov 3, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

danbev commented Nov 3, 2016

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Nov 3, 2016

Choose a reason for hiding this comment

Uh oh!

danbev Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

danbev commented Nov 4, 2016

Uh oh!

danbev commented Nov 4, 2016

Uh oh!

thefourtheye Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

danbev Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

danbev commented Nov 5, 2016

Uh oh!

danbev commented Nov 6, 2016

Uh oh!

danbev commented Nov 7, 2016

Uh oh!

MylesBorins commented Nov 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants