Closed
Conversation
nodejs-github-bot
added
the
c++
Added closing parentheses to LTTNG tracepoint definitions. PR-URL: nodejs#9404 Reviewed-By: <tbd> Reviewed-By: <tbd>
Contributor
Author
|
This builds now but the tracepoints don't show in |
Member
|
pretty odd, probably @thekemkid's wheelhouse |
jasnell
approved these changes
Jan 11, 2017
Member
|
Ping @nodejs/diagnostics |
Contributor
|
Oh crud, just seeing this now -> let me figure out what's up with lttng later and I will post findings. The code however lgtm |
Member
|
@joshgav ... is this still needed? |
Contributor
Author
Contributor
Author
|
closing this since I don't know when I'll be able to pick it up again, will open a new issue at that point. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
Closing parentheses from
TRACEPOINT_EVENTwere removed accidentally in #7462, specifically f1d2792. As a result, building following./configure --with-lttngfails.This PR simply adds closing parentheses to the LTTNG tracepoint definitions to fix this.