build: start comments at beginning of line

[thefourtheye]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

build

Description of change

As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

--

cc @nodejs/build cc @nodejs/collaborators

[thefourtheye]

Before

...
/Applications/Xcode.app/Contents/Developer/usr/bin/make build-addons
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
# Cannot use test/addons/01_callbacks/ test/addons/02_object_factory/ test/addons/03_function_factory/ test/addons/04_wrapping_c_objects/ test/addons/05_factory_of_wrapped_objects/ test/addons/06_passing_wrapped_objects_around/ test/addons/07_atexit_hooks/ test/addons/async-hello-world/ test/addons/at-exit/ test/addons/buffer-free-callback/ test/addons/heap-profiler/ test/addons/hello-world-function-export/ test/addons/hello-world/ test/addons/load-long-path/ test/addons/make-callback-recurse/ test/addons/make-callback/ test/addons/node-module-version/ test/addons/null-buffer-neuter/ test/addons/openssl-binding/ test/addons/parse-encoding/ test/addons/repl-domain-abort/ test/addons/stringbytes-external-exceed-max/ test/addons/symlinked-module/ test/addons/testcfg.py test/addons/testcfg.pyc test/addons/zlib-binding/ here, it's evaluated before
# embedded addons have been generated from the documentation.
for dirname in test/addons/*/; do \
        ./node deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
            --python="/usr/local/opt/python/bin/python2.7" \
            --directory="$PWD/$dirname" \
            --nodedir="$PWD" || exit 1 ; \
    done
...

After

/Applications/Xcode.app/Contents/Developer/usr/bin/make build-addons
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
for dirname in test/addons/*/; do \
        ./node deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
            --python="/usr/local/opt/python/bin/python2.7" \
            --directory="$PWD/$dirname" \
            --nodedir="$PWD" || exit 1 ; \
    done

[jbergstroem]

Good catch.

[silverwind]

LGTM, didn't know this was an issue in make

[jbergstroem]

@silverwind: makefile is whitespace-aware. Try using ifeq() or other functions with a prefixed tab/space :)

[thefourtheye]

Landed in f9504a5

[MylesBorins]

@thefourtheye do you want to backport this?

[thefourtheye]

@thealphanerd Yes. Isn't this landing cleanly?

[MylesBorins]

it does on v6.x but not v4.x

[thefourtheye]

@thealphanerd I backported this in #10364