test: Refactors test/parallel/test-async-wrap-post-did-throw.js#8625
Closed
graphicbeacon wants to merge 2 commits intonodejs:masterfrom
Closed
test: Refactors test/parallel/test-async-wrap-post-did-throw.js#8625graphicbeacon wants to merge 2 commits intonodejs:masterfrom
graphicbeacon wants to merge 2 commits intonodejs:masterfrom
Conversation
…s. Replaces equal method on assert module to strictEqual.
* commit 'a89c23f8ebb8d47e2f577d3594bfb465c1861d25': (30 commits) test: improve test-https-agent.js test: fix test-debug-signal-cluster.js flakyness benchmark: ignore significance when using --runs 1 inspector: fix tests on Windows doc/json: make sure links are correctly passed to marked repl: improve .help message test: make test-tick-processor.js non-flaky doc: link onboarding to contributing guide test: add coverage for client._addHandle() 2016-09-14, Version 6.6.0 (Current) doc: remove duplicate content from readline doc timers: remove unreachable code doc: capitalize arguments' type names in url doc doc: add gibfahn to collaborators doc: add imyller to collaborators doc: standardize rest parameters test: fix flaky test-force-repl inspector: listen on process.debugPort doc: add not-an-aardvark to collaborators doc: link SIGTSTP / SIGCONT events in readline doc ...
Contributor
|
LGTM. Would you care to squash the commits? |
cjihrig
approved these changes
Sep 17, 2016
mscdex
added
async_hooks
Contributor
|
Probably not worthwhile if it conflicts with #8531 in any significant way? |
Member
|
I'd say it's still worthwhile even if the test ends up getting refactored by #8531. This is one of the commits coming from the code and learn over the weekend and the primary intent is to not only help improve the codebase but help new contributors through the process of getting a PR landed. I'm sure that any potential conflict that arises from this PR is likely quite minimal. |
addaleax
approved these changes
Sep 21, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM. Right now this doesn’t conflict with the async-hooks PR anyway.
jasnell
pushed a commit
that referenced
this pull request
Sep 22, 2016
* change var to let * replace equal with strictEqual PR-URL: #8625 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 0a9f56a. Thank you! |
Contributor
Author
|
Thank you all for your help. Really appreciated. |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
* change var to let * replace equal with strictEqual PR-URL: #8625 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
* change var to let * replace equal with strictEqual PR-URL: #8625 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
?
Description of change
This changes var to let in test/parallel/test-async-wrap-post-did-throw.js. Replaces equal method on assert module to strictEqual.