doc: fix a formatting error in buffer.md#8553
Conversation
nodejs-github-bot
added
buffer
|
Hold on, one |
|
Ok, updated. This now uses This basically reverts one change from cc1318b and fixes another change. /cc @mscdex, @jasnell, @trevnorris |
This commit adds more links and reuses existing link references more. PR-URL: #7784 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
I think I'd rather see the 'e.g' portion removed from the first instance and dropping the parens in the second instance. |
|
@mscdex You mean removing «(e.g. |
|
@ChALkeR Yeah, I think it's a bit redundant anyway, especially since we've already linked |
|
@mscdex Done =). |
|
LGTM |
|
/cc @nodejs/documentation, this should be trivial. |
|
LGTM |
1 similar comment
|
LGTM |
It was treated as a link to "e.g. `Uint8Array.from()`". PR-URL: nodejs#8553 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
Merged in ffe8dff. |
It was treated as a link to "e.g. `Uint8Array.from()`". PR-URL: #8553 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
7 participants
Checklist
Affected core subsystem(s)
doc
Description of change
Fixes an error in doc/api/buffer.md, (see the
TypedArray.from()link).It was treated as a link to "e.g.
Uint8Array.from()".Found with remark-lint (see #8551).
Extracted from #8551, as this could land much faster and should probably be backported if needed.