test: fix flaky test-net-write-slow

[Trott]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test net

Description of change

Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516

[Trott]

(Still kind of wonder if the test shouldn't be removed, though. See #7516 for archeological and other details.)

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/3189/

[Trott]

CI is green.

[Trott]

@nodejs/testing

[mscdex]

What about changing the timeout value based on os.platform() or something?

[Trott]

@mscdex That's an option, but I don't think it's preferable in this situation. The arbitrarily large value doesn't make the test take any longer to pass. If it affected the test duration, I'd be inclined to tune the value based on platform. But since it doesn't affect execution time on successful tests, I'd prefer to avoid the complexity of different values on different platforms.

[Trott]

This FreeBSD failure on CI is starting to get a little out of control, so I'm going to try to raise the profile of this fix and argue for an expedited landing (small change, big positive impact, easy to revert, doesn't affect userland code). Raising profile: @nodejs/collaborators

[mcollina]

LGTM

[santigimeno]

LGTM

[Trott]

Landed in 9d654a3. Goodbye, red FreeBSD CI.