Closed
Conversation
Member
|
LGTM, however... I think this PR is a good a place as any to start a discussion about out-of-tree patches. I would like us to adopt a policy where we commit to not landing such patches until after they have been accepted upstream. Even better would be if we persuade the V8 people to back-port the change and simply upgrade. Good idea/bad idea? |
Member
Author
|
Makes sense. v8/v8@a0d0c43 . |
Member
Author
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Feb 25, 2015
Fix: nodejs#461 PR-URL: nodejs#706 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @bnoordhuis
see #461