doc: add added: information for child_process#6927
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add added: information for child_process#6927addaleax wants to merge 1 commit intonodejs:masterfrom
added: information for child_process#6927addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
added
child_process
36 tasks
doc/api/child_process.md
Outdated
Contributor
There was a problem hiding this comment.
Wasn't this util.exec() at that time?
Member
Author
There was a problem hiding this comment.
04c06b9 uses require("child_process").exec in the docs, that’s pretty much what I went by here. But yeah, sorry, this is one version off.
addaleax
force-pushed
the
doc-added-child_process
branch
from
5f4764d to
9b0a754
Compare
doc/api/child_process.md
Outdated
Member
There was a problem hiding this comment.
Close. It was added in v0.5.0.
addaleax
force-pushed
the
doc-added-child_process
branch
from
9b0a754 to
cd91ce8
Compare
Member
Author
|
/cc @nodejs/documentation |
Member
|
LGTM as long as @bnoordhuis is happy |
Member
|
Yes, LGTM. The two errors I pointed out were the only ones. |
Member
Author
|
Landed in 27d2267 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Ref: nodejs#6578 PR-URL: nodejs#6927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Ref: nodejs#6578 PR-URL: nodejs#6927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578