Closed
Conversation
36 tasks
Member
Author
|
ping @nodejs/documentation … anybody minds reviewing this? ;) |
Contributor
|
LGTM. Didn't have a look at the rendering, but couldn't find anything that breaks. Who is doing all that research for history and how? By hand? |
Member
Author
|
@eljefedelrodeodeljefe For the “who”… see the issue linked above, so far that’s me, @bengl and @Trott, but you’re definitely invited to join the party. And the method depends, but |
Contributor
|
Yeah, I was thinking so. Then please have my shout-outs! When I see some I add some... good work! |
Member
Member
Author
|
Landed in ba10ea8 |
2 tasks
addaleax
pushed a commit
that referenced
this pull request
Jun 18, 2016
evanlucas
pushed a commit
that referenced
this pull request
Jun 27, 2016
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Ref: nodejs#6578 PR-URL: nodejs#6717 Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
fs.access and fs.accessSync were added to Node v0.11.15 via 2944934 PR-URL: nodejs#7299 Reviewed-By: Anna Henningsen <anna@addaleax.net> Ref: nodejs#6717 Ref: nodejs#6578
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578