Backport 6039 and 6073: fix flakiness of stringbytes-external#6705
Closed
ofrobots wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
Backport 6039 and 6073: fix flakiness of stringbytes-external#6705ofrobots wants to merge 1 commit intonodejs:v4.x-stagingfrom
ofrobots wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
The tests used to rely on precise timing of when a JavaScript object would be garbage collected to ensure that there is enough memory available on the system. Switch the test to use a malloc/free pair instead. Ref: nodejs#5945 Ref: nodejs#6039 Ref: nodejs#6073
Member
|
LGTM if CI is green |
Contributor
Author
Contributor
|
thanks @ofrobots if CI is green I'll get these landed |
MylesBorins
pushed a commit
that referenced
this pull request
May 13, 2016
The tests used to rely on precise timing of when a JavaScript object would be garbage collected to ensure that there is enough memory available on the system. Switch the test to use a malloc/free pair instead. Ref: #5945 Ref: #6039 Ref: #6073 PR-URL: #6705 Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
ci is green! landed in 04a4a03 |
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
The tests used to rely on precise timing of when a JavaScript object would be garbage collected to ensure that there is enough memory available on the system. Switch the test to use a malloc/free pair instead. Ref: #5945 Ref: #6039 Ref: #6073 PR-URL: #6705 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
As requested, this is a backport of #6039 and #6073 to
v4.x-staging.R= @thealphanerd , @Trott