Merged
Conversation
net streams can request multiple chunks to be written in a synchronous fashion. If this is combined with cork/uncork, en error is currently thrown because of a regression introduced in: 89aeab9 (#4354). Fixes: #6154 PR-URL: #6164 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This makes sure that `kNoZeroFill` flag is not accidentally set by moving the all the flag operations directly inside `createBuffer()`. It safeguards against logical errors like #6006. This also ensures that `kNoZeroFill` flag is always restored to 0 using a try-finally block, as it could be not restored to 0 in cases of failed or zero-size `Uint8Array` allocation. It safeguards against errors like #2930. It also makes the `size > 0` check not needed there. PR-URL: nodejs-private/node-private#30 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
nodejs-github-bot
added
the
meta
Contributor
Author
Member
|
Rubbert stamp LGTM if ci and citgm are green. |
MylesBorins
force-pushed
the
v4.4.4-proposal
branch
2 times, most recently
from
77d4333 to
74e3c00
Compare
Notable changes
* deps:
* update openssl to 1.0.2h. (Shigeki Ohtsu)
[#6551](#6551)
- Please see our blog postfor more info on the security
contents of this release.
https://nodejs.org/en/blog/vulnerability/openssl-may-2016/
MylesBorins
force-pushed
the
v4.4.4-proposal
branch
from
74e3c00 to
9cf628e
Compare
MylesBorins
pushed a commit
that referenced
this pull request
May 6, 2016
Notable changes
* deps:
* update openssl to 1.0.2h. (Shigeki Ohtsu)
[#6551](#6551)
- Please see our blog postfor more info on the security
contents of this release.
https://nodejs.org/en/blog/vulnerability/openssl-may-2016/
PR-URL: #6583
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2016-05-04, Version 4.4.4 'Argon' (LTS), @thealphanerd
Notable changes
Commits
f46952e727] - buffer: safeguard against accidental kNoZeroFill (Сковорода Никита Андреевич) nodejs/node-private#304f1c82f995] - streams: support unlimited synchronous cork/uncork cycles (Matteo Collina) #61641efd96c767] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #6551c450f4a293] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836baedfbae6a] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#1389ff3045e40b] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389dc8dc97db3] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#13892dfeb01213] - deps: copy all openssl header files to include dir (Shigeki Ohtsu) #655172f9952516] - deps: upgrade openssl sources to 1.0.2h (Shigeki Ohtsu) #6551