Conversation
jasnell
added
doc
CHANGELOG.md
Outdated
There was a problem hiding this comment.
added a new line at the end of the file... can pull it out
There was a problem hiding this comment.
that makes sense to me
|
LGTM |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
it looks like these are order, except for this one. Maybe move it down with the other src commits?
|
LGTM with a nit |
|
@jasnell Might it be worth also calling out the npm change that makes npm not run unless node is in the path in the Notable Changes section? I know it was listed in the semver-major commits, but it's under tools, which makes it quite hard to spot. I understand why the change was made, but it does mean that you can no longer simply untar and then run Original PR: #6098 Commit: 8ffa20c I was going to open an issue/pull request, but as you're already making changes to the Changelog I thought it might be easier to do both together. Let me know if you'd rather I opened a separate PR. |
Not quite sure how, but quite a few of the commits were missing from the original changelog generated for v6 relative to v5.11.0. This updates the change log.
jasnell
force-pushed
the
fix-v6-changelog
branch
from
a9da515 to
29217cd
Compare
|
@evanlucas @gibm ... done. |
Not quite sure how, but quite a few of the commits were missing from the original changelog generated for v6 relative to v5.11.0. This updates the change log. PR-URL: nodejs#6435 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
landed in b8f035b |
Not quite sure how, but quite a few of the commits were missing from the original changelog generated for v6 relative to v5.11.0. This updates the change log. PR-URL: nodejs#6435 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Not quite sure how, but quite a few of the commits were missing from the original changelog generated for v6 relative to v5.11.0. This updates the change log. PR-URL: #6435 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Not quite sure how, but quite a few of the commits were missing from the original changelog generated for v6 relative to v5.11.0. This updates the change log. PR-URL: nodejs#6435 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
4 participants
Checklist
Affected core subsystem(s)
doc (changelog)
Description of change
Not quite sure how, but quite a few of the commits were missing from the original changelog generated for v6 relative to v5.11.0. This updates the change log.
(would need to land on v6 also)
/cc @Fishrock123