doc: ensures consistent grammar in node.1 file#6426
Closed
justshiv wants to merge 1 commit intonodejs:masterfrom
Closed
doc: ensures consistent grammar in node.1 file#6426justshiv wants to merge 1 commit intonodejs:masterfrom
justshiv wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
@nodejs/documentation |
Member
|
LGTM |
Member
|
CI, just to be thorough: https://ci.nodejs.org/job/node-test-pull-request/2410/ |
Contributor
|
LGTM |
Member
|
Only CI failure is a currently-problematic test on OS X, so CI is good. |
Member
|
Should the commit message say |
Contributor
|
LGTM. Commit would be better as |
Contributor
Author
|
Ah sorry, the convention in my org is to use third person present verbs 😄 |
Contributor
|
@justshiv Btw, git thinks your name is If you're ok with that, I'll land this as-is. But if you'd like you can set your name to git by doing: and then |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 2, 2016
PR-URL: nodejs#6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
Thanks, landed in 8ebec08 We can always |
Fishrock123
pushed a commit
that referenced
this pull request
May 4, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced May 4, 2016
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
PR-URL: nodejs#6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
oh hey @justshiv !!! so happy to see you got something into core |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Grammar in node.1 file was inconsistent when starting man-page responses (Open vs Opens). I've changed this to ensure these responses are consistent throughout.