src: fix -Wunused-result warning in e38bade#6276
Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix -Wunused-result warning in e38bade#6276thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Conversation
thefourtheye
added
the
lib / src
This patch fixes the warning introduced by the changes in e38bade. Ref: nodejs#6092
thefourtheye
force-pushed
the
fix-warning
branch
from
aa99825 to
52a40be
Compare
Contributor
Author
| Local<Object> events_obj = Object::New(env->isolate()); | ||
| events_obj->SetPrototype(env->context(), Null(env->isolate())); | ||
| maybe = events_obj->SetPrototype(env->context(), Null(env->isolate())); | ||
| CHECK(maybe.FromJust()); |
Member
There was a problem hiding this comment.
Could fit on one line as CHECK(events_obj->SetPrototype(env->context(), Null(env->isolate()).FromJust());, couldn't it?
Contributor
Author
There was a problem hiding this comment.
@bnoordhuis Nope, it comes to 83 characters
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
mscdex
added
the
c++
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
Author
|
Landing this now, as its a trivial change and got 4 CTC LGTMs. Landed in 697790c |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
This patch fixes the warning introduced by the changes in e38bade. Ref: nodejs#6092 PR-URL: nodejs#6276 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
src
Description of change
This patch fixes the warning introduced by the changes in e38bade.
cc @Fishrock123 @jasnell @mscdex
Ref: #6092