Skip to content

test: move debugger tests to sequential#6205

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:move
Closed

test: move debugger tests to sequential#6205
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:move

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 14, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

test-debugger-util-regression fails with make test sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with make test-ci, when run via tools/test.py or directly
from the command line with ./node test/parallel/test-debugger-util-regression.js.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix make test
promptly.

Fixes: #6201

@Trott Trott added debugger test Issues and PRs related to the tests. labels Apr 14, 2016
@Trott
test: move debugger tests to sequential
821a9c3 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

Fixes: nodejs#6201
@Trott
Copy link
Member Author

Trott commented Apr 14, 2016

I suspect the issue is that the tests are relying on the default debug port and so they are colliding when run in parallel. But that's just a guess for the moment.

Since they are the only debugger tests in parallel, it wasn't until the second test was introduced that the issue became apparent.

/cc @nodejs/testing

@Trott Trott changed the title test: move debugger-util-regression to sequential test: move debugger tests to sequential Apr 14, 2016
@Trott
Copy link
Member Author

Trott commented Apr 14, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2266/

@Trott Trott mentioned this pull request Apr 14, 2016
Closed
@Trott
Copy link
Member Author

Trott commented Apr 14, 2016

CI is totally green. Can I get an LGTM so we can land this? /cc @Fishrock123 @mhdawson

I think expediting this is justified. While CI isn't affected, having make test broken is Not Good. And this is a very low risk fix. We can take more time and care (if we want to) to adjust the tests to make them parallel-capable, but moving them unchanged to sequential is about as close to zero-risk as you can get.

@Fishrock123
Copy link
Contributor

Fishrock123 commented Apr 15, 2016

@Trott Also see the error on master. This fixes it for me. LGTM!

@jbergstroem
Copy link
Member

jbergstroem commented Apr 15, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Apr 15, 2016
@Trott
test: move debugger tests to sequential
00b2219 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: nodejs#6205
Fixes: nodejs#6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott
Copy link
Member Author

Trott commented Apr 15, 2016

Landed in 00b2219

@Trott Trott closed this Apr 15, 2016
@santigimeno
Copy link
Member

santigimeno commented Apr 16, 2016

PR to move the tests back to parallel: #6246

MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: move debugger tests to sequential
ec11dfb 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: #6205
Fixes: #6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: move debugger tests to sequential
5b42ef5 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: #6205
Fixes: #6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Apr 21, 2016
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 21, 2016

@Trott lts?

@santigimeno santigimeno mentioned this pull request Apr 21, 2016
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@Trott @MylesBorins
test: move debugger tests to sequential
8779967 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: #6205
Fixes: #6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott
Copy link
Member Author

Trott commented Apr 21, 2016

@thealphanerd Yes. (And then also @santigimeno's later PR that fixes them up for parallelism and moves them back!)

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 21, 2016

this should land with b95160d

jasnell pushed a commit that referenced this pull request Apr 26, 2016
@Trott @jasnell
test: move debugger tests to sequential
5cce87d 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: #6205
Fixes: #6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
santigimeno pushed a commit to santigimeno/node that referenced this pull request May 18, 2016
@Trott @santigimeno
test: move debugger tests to sequential
48e50cb 
The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: nodejs#6205
Fixes: nodejs#6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott Trott deleted the move branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests: test-debugger-util-regression failure "program should not terminate"

5 participants

@Trott @Fishrock123 @jbergstroem @santigimeno @MylesBorins