src: use string_view in WriteReport()#60201
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 12, 2025
Merged
Conversation
Since 075936b, `TriggerNodeReport()` takes `std::string_view` arguments directly.
cjihrig
approved these changes
Oct 10, 2025
richardlau
approved these changes
Oct 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60201 +/- ##
==========================================
+ Coverage 88.53% 88.56% +0.03%
==========================================
Files 704 704
Lines 208087 208087
Branches 40006 40017 +11
==========================================
+ Hits 184223 184288 +65
+ Misses 15869 15815 -54
+ Partials 7995 7984 -11
🚀 New features to boost your workflow:
|
Collaborator
lpinca
approved these changes
Oct 10, 2025
anonrig
approved these changes
Oct 10, 2025
daeyeon
approved these changes
Oct 11, 2025
RaisinTen
approved these changes
Oct 11, 2025
Collaborator
|
Landed in 3ac88a7 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 075936b,
TriggerNodeReport()takesstd::string_viewarguments directly.