zlib: Fix use after null when calling .close#5982
Closed
lightsofapollo wants to merge 1 commit intonodejs:masterfrom
Closed
zlib: Fix use after null when calling .close#5982lightsofapollo wants to merge 1 commit intonodejs:masterfrom
lightsofapollo wants to merge 1 commit intonodejs:masterfrom
Conversation
An internal zlib error may cause _handle to be set to null. Close now will check if there is a _handle prior to calling .close on it.
Contributor
|
LGTM |
Member
|
LGTM too, if that’s worth anything. Adding a test for this should not be too complicated, I think? |
Contributor
Author
|
I will give a shot adding a test tonight thanks for quick r? |
Contributor
|
LGTM. +1 to a test. |
Member
|
LGTM with a test |
Member
|
ping @lightsofapollo ... have you had a chance to look at the test yet? |
Member
|
CI: https://ci.nodejs.org/job/node-test-commit/2962/ |
3 tasks
Member
Contributor
|
needs to be included with f8e507e when backported |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
An internal zlib error may cause _handle to be set to null. Close now will check if there is a _handle prior to calling .close on it. PR-URL: nodejs#5982 Fixes: nodejs#6034 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Description of change
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.