v8: add cpu profile by theanarkh · Pull Request #59807 · nodejs/node

theanarkh · 2025-09-08T13:47:42Z

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2025-09-08T13:47:48Z

Review requested:

@nodejs/web-infra

codecov · 2025-09-08T14:47:15Z

Codecov Report

❌ Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.45%. Comparing base (24ded11) to head (10b2275).
⚠️ Report is 140 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_v8.cc	77.41%	2 Missing and 5 partials ⚠️
lib/v8.js	94.11%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59807      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         703      703              
  Lines      207544   207609      +65     
  Branches    40013    40026      +13     
==========================================
+ Hits       183587   183638      +51     
+ Misses      15965    15957       -8     
- Partials     7992     8014      +22

Files with missing lines	Coverage Δ
src/node_v8.h	`40.00% <ø> (ø)`
lib/v8.js	`99.02% <94.11%> (-0.35%)`	⬇️
src/node_v8.cc	`80.63% <77.41%> (-0.64%)`	⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

juanarbol

Rubber stamp LGTM!

I wasn't expecting the serializer to land Node.js! <3

nodejs-github-bot · 2025-09-08T21:54:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69144/

src/node_v8.cc

test/parallel/test-v8-cpu-profile.js

jasnell · 2025-09-15T12:14:08Z

test/parallel/test-v8-cpu-profile.js

+const handle = v8.startCpuProfile();
+const profile = handle.stop();
+assert.ok(typeof profile === 'string');
+assert.ok(profile.length > 0);


Nit: a test that exercises the using syntax would be ideal also

nodejs-github-bot · 2025-09-15T12:55:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69237/

nodejs-github-bot · 2025-09-28T14:55:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69426/

nodejs-github-bot · 2025-09-30T01:37:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69454/

nodejs-github-bot · 2025-09-30T03:09:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69455/

nodejs-github-bot · 2025-10-09T18:00:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69649/

nodejs-github-bot · 2025-10-10T06:05:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69652/

nodejs-github-bot · 2025-10-11T13:30:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69685/

nodejs-github-bot · 2025-10-11T17:20:59Z

Landed in f9fcc74

PR-URL: #59807 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: http: * (SEMVER-MINOR) add optimizeEmptyRequests server option (Rafael Gonzaga) #59778 src: * (SEMVER-MINOR) add watch config namespace (Marco Ippolito) #60178 * (SEMVER-MINOR) add an option to make compile cache portable (Aditi) #58797 v8: * (SEMVER-MINOR) add cpu profile (theanarkh) #59807 PR-URL: #60615

PR-URL: #59807 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: http: * (SEMVER-MINOR) add optimizeEmptyRequests server option (Rafael Gonzaga) #59778 lib: * (SEMVER-MINOR) add options to util.deprecate (Rafael Gonzaga) #59982 module: * (SEMVER-MINOR) mark type stripping as stable (Marco Ippolito) #60600 node-api: * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) #59953 sqlite: * (SEMVER-MINOR) allow setting defensive flag (Bart Louwers) #60217 src: * (SEMVER-MINOR) add watch config namespace (Marco Ippolito) #60178 * (SEMVER-MINOR) add an option to make compile cache portable (Aditi) #58797 src,permission: * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) #59711 v8: * (SEMVER-MINOR) add cpu profile (theanarkh) #59807 PR-URL: #61001

Notable changes: http: * (SEMVER-MINOR) add optimizeEmptyRequests server option (Rafael Gonzaga) nodejs#59778 lib: * (SEMVER-MINOR) add options to util.deprecate (Rafael Gonzaga) nodejs#59982 module: * (SEMVER-MINOR) mark type stripping as stable (Marco Ippolito) nodejs#60600 node-api: * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) nodejs#59953 sqlite: * (SEMVER-MINOR) allow setting defensive flag (Bart Louwers) nodejs#60217 src: * (SEMVER-MINOR) add watch config namespace (Marco Ippolito) nodejs#60178 * (SEMVER-MINOR) add an option to make compile cache portable (Aditi) nodejs#58797 src,permission: * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) nodejs#59711 v8: * (SEMVER-MINOR) add cpu profile (theanarkh) nodejs#59807 PR-URL: nodejs#61001

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 8, 2025

theanarkh force-pushed the v8_add_cpu_profile_api branch from 7214ba0 to 7dcb480 Compare September 8, 2025 13:50

theanarkh added v8 module Issues and PRs related to the "v8" subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 8, 2025

juanarbol approved these changes Sep 8, 2025

View reviewed changes

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2025

theanarkh force-pushed the v8_add_cpu_profile_api branch 2 times, most recently from b41c98b to d50d6e9 Compare September 10, 2025 18:01

jasnell reviewed Sep 13, 2025

View reviewed changes

src/node_v8.cc Show resolved Hide resolved

jasnell reviewed Sep 13, 2025

View reviewed changes

test/parallel/test-v8-cpu-profile.js Outdated Show resolved Hide resolved

theanarkh force-pushed the v8_add_cpu_profile_api branch from d50d6e9 to ff0cced Compare September 14, 2025 14:25

jasnell reviewed Sep 15, 2025

View reviewed changes

jasnell approved these changes Sep 15, 2025

View reviewed changes

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025

theanarkh added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 16, 2025

v8: add cpu profile

10b2275

theanarkh force-pushed the v8_add_cpu_profile_api branch from bf4b7cf to 10b2275 Compare September 23, 2025 12:55

theanarkh removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2025

theanarkh requested review from jasnell and juanarbol September 28, 2025 13:11

jasnell approved these changes Sep 28, 2025

View reviewed changes

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025

juanarbol approved these changes Sep 28, 2025

View reviewed changes

theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025

nodejs-github-bot merged commit f9fcc74 into nodejs:main Oct 11, 2025
60 of 62 checks passed

theanarkh mentioned this pull request Oct 12, 2025

v8: add heap profile API #60231

Open

4 tasks

RafaelGSS mentioned this pull request Oct 13, 2025

2025-10-15, Version 25.0.0 (Current) #59896

Merged

9 tasks

aduh95 pushed a commit that referenced this pull request Oct 31, 2025

v8: add cpu profile

879e4c0

PR-URL: #59807 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

github-actions bot mentioned this pull request Nov 7, 2025

2025-11-11, Version 24.12.0 'Krypton' (LTS) #60615

Closed

targos pushed a commit that referenced this pull request Nov 18, 2025

v8: add cpu profile

05d7509

PR-URL: #59807 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

github-actions bot mentioned this pull request Dec 9, 2025

2025-12-10, Version 24.12.0 'Krypton' (LTS) #61001

Merged

This was referenced Jan 3, 2026

chore(nix): update flake.lock (deno, git, go +3 more) i9wa4/dotfiles#76

Closed

chore(nix): update flake.lock (act, actionlint, awscli2 +25 more) i9wa4/dotfiles#79

Closed

Uh oh!

Conversation

theanarkh commented Sep 8, 2025

Uh oh!

nodejs-github-bot commented Sep 8, 2025

Uh oh!

codecov bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

jasnell Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 15, 2025

Uh oh!

nodejs-github-bot commented Sep 28, 2025

Uh oh!

nodejs-github-bot commented Sep 30, 2025

Uh oh!

nodejs-github-bot commented Sep 30, 2025

Uh oh!

nodejs-github-bot commented Oct 9, 2025

Uh oh!

nodejs-github-bot commented Oct 10, 2025

Uh oh!

nodejs-github-bot commented Oct 11, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 8, 2025 •

edited

Loading