Closed
Conversation
Member
|
LGTM. Just a suggestion: "Method Load" is kind of a bad name, "Function Compiled" is closer to the truth. |
joaocgreis
added a commit
that referenced
this pull request
Mar 31, 2016
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #5936
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/2110/ all ok except a slave failure Landed in: 1845c4f Thanks @bnoordhuis ! |
Member
|
Thanks for the fix - I tested this locally and I like the change, forgot to comment. |
Member
|
is this relevant to v4 at all? |
Member
Author
|
@jasnell I don't think so, this is a new feature. Added the don't land label, feel free to remove if that was not the correct thing or not consensual. |
Member
|
Works for me. |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2016
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #5936
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
ETW
Description of change
Note: #5657 should land before this, because this does not include the generated files.
A log of ETW events can be produced with:
The resulting
etlfile can be open in Event Viewer.Without this change, the description box shows an error message:
This adds descriptions to all events, replacing the error message in the Event Viewer.
cc @nodejs/platform-windows