test: add known_issues test for GH-2148#5920
Closed
Trott wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
Trott
added
process
Contributor
There was a problem hiding this comment.
Won't this technically be + 2 on Windows?
Member
Author
There was a problem hiding this comment.
Probably. Good point. Maybe the thing to do is compare stdout.trim().length in the assertion so as to avoid any assumptions whatsoever about the line separator?
Contributor
There was a problem hiding this comment.
Yeah, and we may want to compare the (trimmed) output instead of comparing the lengths just to be extra sure we get what we expect.
| } | ||
|
|
||
| const stdout = execSync(`${process.execPath} ${__filename} child`) | ||
| .toString() |
Contributor
There was a problem hiding this comment.
nit: maybe these would look a little less oddly placed if they were lined up with the first e in execSync()?
Contributor
There was a problem hiding this comment.
Maybe just do this?
const argv = `${process.execPath} ${__filename} child`
Contributor
|
One nit but otherwise LGTM. |
Member
Author
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 31, 2016
PR-URL: nodejs#5920 Refs: nodejs#2148 Reviewed-By: Brian White <mscdex@mscdex.net>
Member
Author
|
Landed in 33c27f8 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test, process
Description of change
test: add known_issues test for GH-2148
Refs: #2148