test: deflake test-runner-watch-mode-kill-signal#58952
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jul 7, 2025
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Collaborator
dario-piotrowicz
added
the
flaky-test
dario-piotrowicz
force-pushed
the
dario/deflake-watch-mode-kill-signal-test
branch
2 times, most recently
from
c40725d to
4c1b29f
Compare
dario-piotrowicz
force-pushed
the
dario/deflake-watch-mode-kill-signal-test
branch
from
4c1b29f to
971a1ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58952 +/- ##
==========================================
+ Coverage 89.96% 90.06% +0.09%
==========================================
Files 640 640
Lines 188454 188471 +17
Branches 36892 36979 +87
==========================================
+ Hits 169546 169739 +193
+ Misses 11608 11430 -178
- Partials 7300 7302 +2 🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Jul 7, 2025
jasnell
approved these changes
Jul 7, 2025
Ethan-Arrowood
approved these changes
Jul 7, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
MoLow
approved these changes
Jul 7, 2025
dario-piotrowicz
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 35c85a2 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
PR-URL: #58952 Refs: nodejs/reliability#1250 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58952 Refs: nodejs/reliability#1250 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58952 Refs: nodejs/reliability#1250 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Jul 27, 2025
PR-URL: #58952 Refs: nodejs/reliability#1250 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to deflake the tests I've refactored making them much clearer and more performant (since there are no longer
setTimeoutcalls), as far as I can tell the flake is also gone 🙂Results:
Ref: nodejs/reliability#1250