Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
Member
|
Tests are failing because nodejs/undici#4083 got fixed. Going to update the tests and remove the FIXME... |
7 tasks
`proxy-connection: keep-alive` is now correctly managed by undici after https://redirect.github.com/nodejs/undici/pull/4128
Member
|
Looks like only the keep-alive part is fixed, the tunnling part is still a bit inconsistent with curl, left a comment in nodejs/undici#4180 (comment) and kept nodejs/undici#4083 open. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58859 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 640 640
Lines 188493 188493
Branches 36971 36968 -3
=======================================
+ Hits 169843 169849 +6
+ Misses 11358 11351 -7
- Partials 7292 7293 +1 🚀 New features to boost your workflow:
|
legendecas
approved these changes
Jun 27, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Author
legendecas
added
request-ci
RafaelGSS
approved these changes
Jun 27, 2025
RafaelGSS
added
author ready
nodejs-github-bot
force-pushed
the
actions/tools-update-undici
branch
from
33d5140 to
68d0b3f
Compare
nodejs-github-bot
added
commit-queue-failed
This comment was marked as duplicate.
This comment was marked as duplicate.
aduh95
force-pushed
the
actions/tools-update-undici
branch
from
68d0b3f to
33d5140
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
aduh95
removed
the
commit-queue-failed
Contributor
|
Landed in 0b88e09 |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58859 Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95
added
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of undici to 7.11.0.