build: option to use custom inspector_protocol path#58839
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 28, 2025
Merged
build: option to use custom inspector_protocol path#58839nodejs-github-bot merged 1 commit intonodejs:mainfrom
inspector_protocol path#58839nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
approved these changes
Jun 26, 2025
codebytere
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
Out of curiosity, is Electron custom protocol a superset of the Node or there are some features that need to be removed? I was always wondering if the protocol should be extensible with possibility to write new domains in client-space JS. |
lpinca
approved these changes
Jun 26, 2025
Collaborator
addaleax
approved these changes
Jun 27, 2025
addaleax
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 98da424 |
ronijames008
pushed a commit
to ronijames008/node
that referenced
this pull request
Jun 28, 2025
PR-URL: nodejs#58839 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58839 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58839 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58839 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows building against
//third_party/inspector_protocolwhich would align Electron when building with chromium shared dependencies.This allows us to remove a patch
The precursor to this PR was merged via #58001 which contains changes necessitated by this CL