doc: fix stability 1.x links excluding the decimal digit

[dario-piotrowicz]

Pretty minor, this is just addressing a minimal UI quirk I noticed with the Stability 1.x links where the decimal digits are not included in the hyperlink

PS: I've also moved the regex outside of the preprocessElements function, as there is no reason/benefit to have the regex rebuilt for every file (having it outside might save some precious nanoseconds when building the docs 😅).

Before

After

[nodejs-github-bot]

Review requested:

• @nodejs/web-infra

[Hardanish-Singh]

LGTM!

[ovflowd]

parseInt will only grab the numeric pieces of "number" right?

[dario-piotrowicz]

Yes, in the regex that the part for number is /\d(?:\.\d)? meaning that the number matched value can be a single digit optionally followed by a dot followed by another digit, parseInt run on such numbers/strings always returns the integer part of the number:

And that's the part we need based on the css classes we have:

node/doc/api_assets/style.css

Lines 324 to 338 in d7becc5

	.api_stability_0 {
	background-color: var(--red1);
	}
	.api_stability_1 {
	background-color: var(--red3);
	}
	.api_stability_2 {
	background-color: var(--green2);
	}
	.api_stability_3 {
	background-color: var(--blue1);
	}

[avivkeller]

I used the same trick in the web generator :-)

[ovflowd]

I just wanted to confirm. I recall either parseInt or Number() parse the numeric parseable stuff until it finds something non-numeric.

[avivkeller]

No, not until it finds something non-numeric. It parses the float since it's a valid number, and flattens it to an integer.

[avivkeller]

Note to web infra teams: this doesn't need to be ported to api-docs-tooling, I (independently from this) changed the logic to something similar in the web generator PR.

[dario-piotrowicz]

Note to web infra teams: this doesn't need to be ported to api-docs-tooling, I (independently from this) changed the logic to something similar in the web generator PR.

Thanks, I was about to ask someone at some point if this needed porting (as I haven't looked too much into the new tooling I must admit 😓) but you saved me the effort 🫶

[nodejs-github-bot]

Landed in d8de8f3

[ovflowd]

I wish I could have landed this haha; Ah how it sucks not being a collaborator anymore lol