Skip to content

tools: make nodedownload module compatible with Python 3.14#58752

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
frenzymadness:py314
Jun 22, 2025
Merged

tools: make nodedownload module compatible with Python 3.14#58752
nodejs-github-bot merged 1 commit intonodejs:mainfrom
frenzymadness:py314

Conversation

@frenzymadness
Copy link
Contributor

FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14.

Fixes: #58740

FancyURLopener and URLopener have been deprecated since
Python 3.3 and they are removed completely from 3.14.

Fixes: nodejs#58740
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Jun 18, 2025
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2025
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit dfcb824 into nodejs:main Jun 22, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in dfcb824

RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
FancyURLopener and URLopener have been deprecated since
Python 3.3 and they are removed completely from 3.14.

Fixes: #58740
PR-URL: #58752
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
FancyURLopener and URLopener have been deprecated since
Python 3.3 and they are removed completely from 3.14.

Fixes: #58740
PR-URL: #58752
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
FancyURLopener and URLopener have been deprecated since
Python 3.3 and they are removed completely from 3.14.

Fixes: #58740
PR-URL: #58752
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
chenx97 pushed a commit to AOSC-Tracking/node that referenced this pull request Dec 8, 2025
SQUASHED UPSTREAM COMMITS:

tools: make nodedownload module compatible with Python 3.14

FancyURLopener and URLopener have been deprecated since
Python 3.3 and they are removed completely from 3.14.

Fixes: nodejs#58740
PR-URL: nodejs#58752
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

build: test on Python 3.14 release candidate 3

Python v3.14 -- October 7th
* https://www.python.org/download/pre-releases
* https://www.python.org/downloads/release/python-3140rc3

PR-URL: nodejs#59983
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Feb 5, 2026
- Backport chromium-review.googlesource.com/c/v8/v8/+/7540554 to fix the long-standing nodejs heisenbug Sporadic Nodejs segfault on sg2042 revyos/revyos#27. Upstream PR: nodejs/node#61687
- `--nocheck` is needed. There are test failures.
- Backport nodejs/node#58752 to fix build
  failure with Python 3.14
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Feb 5, 2026
- Backport chromium-review.googlesource.com/c/v8/v8/+/7540554 to fix the long-standing nodejs heisenbug Sporadic Nodejs segfault on sg2042 revyos/revyos#27. Upstream PR: nodejs/node#61687
- `--nocheck` is needed. There are test failures.
- Backport nodejs/node#58752 to fix build
  failure with Python 3.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FancyURLopener and URLopener have been removed from Python 3.14

5 participants