tools: make nodedownload module compatible with Python 3.14#58752
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 22, 2025
Merged
tools: make nodedownload module compatible with Python 3.14#58752nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14. Fixes: nodejs#58740
anonrig
approved these changes
Jun 19, 2025
jasnell
approved these changes
Jun 20, 2025
Collaborator
Collaborator
|
Landed in dfcb824 |
This was referenced Jun 23, 2025
chenx97
pushed a commit
to AOSC-Tracking/node
that referenced
this pull request
Dec 8, 2025
SQUASHED UPSTREAM COMMITS: tools: make nodedownload module compatible with Python 3.14 FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14. Fixes: nodejs#58740 PR-URL: nodejs#58752 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> build: test on Python 3.14 release candidate 3 Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Feb 5, 2026
- Backport chromium-review.googlesource.com/c/v8/v8/+/7540554 to fix the long-standing nodejs heisenbug Sporadic Nodejs segfault on sg2042 revyos/revyos#27. Upstream PR: nodejs/node#61687 - `--nocheck` is needed. There are test failures. - Backport nodejs/node#58752 to fix build failure with Python 3.14
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Feb 5, 2026
- Backport chromium-review.googlesource.com/c/v8/v8/+/7540554 to fix the long-standing nodejs heisenbug Sporadic Nodejs segfault on sg2042 revyos/revyos#27. Upstream PR: nodejs/node#61687 - `--nocheck` is needed. There are test failures. - Backport nodejs/node#58752 to fix build failure with Python 3.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14.
Fixes: #58740