fs: add support to `Dir` for explicit resource management by aduh95 · Pull Request #58206 · nodejs/node

aduh95 · 2025-05-07T02:20:54Z

No description provided.

codecov · 2025-05-07T03:32:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (942862f) to head (a799f76).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58206      +/-   ##
==========================================
- Coverage   90.20%   90.18%   -0.02%     
==========================================
  Files         629      629              
  Lines      186641   186658      +17     
  Branches    36667    36660       -7     
==========================================
- Hits       168353   168337      -16     
- Misses      11115    11118       +3     
- Partials     7173     7203      +30

Files with missing lines	Coverage Δ
lib/internal/fs/dir.js	`94.45% <100.00%> (+0.27%)`	⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-05-07T07:10:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66673/

lib/internal/fs/dir.js

nodejs-github-bot · 2025-05-08T08:56:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66702/

lib/internal/fs/dir.js

nodejs-github-bot · 2025-05-10T08:43:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66740/

nodejs-github-bot · 2025-05-11T14:53:22Z

Landed in 4a86be2

PR-URL: #58206 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406

PR-URL: #58206 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

Notable changes: assert: * (SEMVER-MINOR) mark partialDeepStrictEqual() as stable (Ruben Bridgewater) #57370 doc: * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 PR-URL: #58665

PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370 doc: * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http2: * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437 PR-URL: #58665

PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370 doc: * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http2: * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437 PR-URL: #58665

PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label May 7, 2025

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 7, 2025

jasnell approved these changes May 7, 2025

View reviewed changes

aduh95 force-pushed the fs-using-dir branch from 2e13ffc to c7fa030 Compare May 7, 2025 06:52

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2025

LiviaMedeiros approved these changes May 7, 2025

View reviewed changes

lib/internal/fs/dir.js Outdated Show resolved Hide resolved

aduh95 commented May 8, 2025

View reviewed changes

lib/internal/fs/dir.js Show resolved Hide resolved

aduh95 added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 8, 2025

fs: add to Dir support for explicit resource management

a799f76

aduh95 force-pushed the fs-using-dir branch from 9cf25d5 to a799f76 Compare May 10, 2025 08:39

LiviaMedeiros approved these changes May 10, 2025

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels May 10, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025

nodejs-github-bot merged commit 4a86be2 into nodejs:main May 11, 2025
64 checks passed

aduh95 deleted the fs-using-dir branch May 11, 2025 19:34

targos pushed a commit that referenced this pull request May 16, 2025

fs: add to Dir support for explicit resource management

fcead7c

PR-URL: #58206 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

aduh95 mentioned this pull request May 19, 2025

workers: make Worker async disposable #58385

Closed

github-actions bot mentioned this pull request May 20, 2025

2025-05-21, Version 24.1.0 (Current) #58406

Merged

aduh95 added a commit that referenced this pull request Jun 10, 2025

fs: add to Dir support for explicit resource management

1b38476

PR-URL: #58206 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

github-actions bot mentioned this pull request Jun 10, 2025

2025-06-24, Version 22.17.0 'Jod' (LTS) #58665

Merged

Renegade334 mentioned this pull request Jun 12, 2025

fs: make Dir disposers idempotent #58692

Merged

RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025

fs: make Dir disposers idempotent

96c78d7

PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Jul 21, 2025

fs: make Dir disposers idempotent

c095b6f

PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request Jul 24, 2025

fs: make Dir disposers idempotent

141b2b1

PR-URL: #58692 Refs: #58206 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fs: add support to `Dir` for explicit resource management#58206

fs: add support to `Dir` for explicit resource management#58206
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:fs-using-dir

aduh95 commented May 7, 2025

Uh oh!

codecov bot commented May 7, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 10, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

aduh95 commented May 7, 2025

Uh oh!

codecov bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 10, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented May 7, 2025 •

edited

Loading