Strip non-free ICC profile and fix test, take 2#5813
Closed
kapouer wants to merge 2 commits intonodejs:masterfrom
Closed
Strip non-free ICC profile and fix test, take 2#5813kapouer wants to merge 2 commits intonodejs:masterfrom
kapouer wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
|
LGTM although I'm +0 on the change. I don't think the case (someone making a modification of the sRGB profile of the picture by mistake) is very realistic but then again the fix looks simple enough. |
Contributor
Author
|
It is not realistic indeed, it's really a matter of not having provable non-free material in an open-source project. |
Member
|
Ok, if it's important to you morally and no one has an objection about the content then I'm +1. |
Contributor
Author
|
It is, especially when i put my debian maintainer hat on ;) |
Member
|
LGTM |
Member
|
lgtm, thanks @kapouer |
Member
Member
|
Unrelated build bot failure |
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2016
PR-URL: #5813 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Member
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
PR-URL: #5813 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Conflicts: test/parallel/test-zlib-params.js
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5813 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2016
PR-URL: #5813 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #5811.