src: use ranges library (C++20) to simplify code#57975
Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom Apr 25, 2025
Merged
src: use ranges library (C++20) to simplify code#57975nodejs-github-bot merged 6 commits intonodejs:mainfrom
nodejs-github-bot merged 6 commits intonodejs:mainfrom
Conversation
anonrig
approved these changes
Apr 22, 2025
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src: use ranges library (C++20) to simplify code ⚠ - breaking long lines ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14598958420 |
anonrig
approved these changes
Apr 22, 2025
Member
|
Looks like a missing |
Member
Author
|
@richardlau good catch. |
Member
|
@lemire It seems it doesn't build on any platforms at all |
jasnell
approved these changes
Apr 23, 2025
Member
Author
It should build. Let us find out what the issue is. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57975 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.02%
==========================================
Files 630 630
Lines 186169 186169
Branches 36479 36479
==========================================
- Hits 168082 168062 -20
- Misses 10971 10974 +3
- Partials 7116 7133 +17
🚀 New features to boost your workflow:
|
Member
Author
|
@anonrig I am unhappy with the formatting of the code, but it works now !!!!!!!!! |
anonrig
approved these changes
Apr 24, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
codebytere
approved these changes
Apr 25, 2025
Collaborator
|
Landed in 25fe802 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57975 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57975 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses C++20 ranges to slightly simplify a piece of code. To be honest, the real motivation of this PR is to introduce ranges and test whether the platforms play nice with ranges. If so, then this could be generalized in the code base.