test: force GC in test-file-write-stream4#57930
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 20, 2025
Merged
test: force GC in test-file-write-stream4#57930nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Member
Author
|
Alternative to #57927. |
Member
Author
jasnell
approved these changes
Apr 18, 2025
Member
jasnell
left a comment
There was a problem hiding this comment.
I'm not sure that this and the PR marking this test as flaky are mutually exclusive. We can do both then remove the flaky flag once we believe it has been fixed.
4c82143 to
563da32
Compare
Member
Author
|
In my opinion, landing both does not make much sense. |
Member
Author
Before the patch After the patch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57930 +/- ##
==========================================
+ Coverage 90.26% 90.27% +0.01%
==========================================
Files 630 630
Lines 185933 185933
Branches 36450 36443 -7
==========================================
+ Hits 167829 167853 +24
+ Misses 10972 10964 -8
+ Partials 7132 7116 -16 🚀 New features to boost your workflow:
|
LiviaMedeiros
approved these changes
Apr 19, 2025
Collaborator
Reduce `test/parallel/test-file-write-stream4.js` flakiness. Refs: nodejs#57927
563da32 to
5bfd30f
Compare
Collaborator
anonrig
approved these changes
Apr 20, 2025
Collaborator
|
Landed in 422529a |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce
test/parallel/test-file-write-stream4.jsflakiness.Refs: #57927