2025-04-22, Version 20.19.1 'Iron' (LTS)#57896
Merged
UlisesGascon merged 8 commits intov20.xfrom Apr 22, 2025
Merged
Conversation
The backported patches already include the commit that disables the warning unless `--trace-require-module` is explicitly used. Correct the changelog to match the status. PR-URL: #57529 Fixes: #57517 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #57442 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Fixes: #57636 Co-authored-by: Robert Nagy <ronagy@icloud.com> PR-URL: #57640 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
The output of the `s_client` command invoked by the test has changed in the OpenSSL 3.5.0 version of `s_client`. Update the test so that it works with both the old and new output -- the `s_client` binary being run may not be at the exact same version of OpenSSL as used by Node.js so the updated test allows either output. PR-URL: #57477 Refs: openssl/openssl#26734 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Apr 16, 2025
Notable changes: PR-URL: #57896
Collaborator
|
Review requested:
|
github-actions
bot
added
the
v20.x
Member
|
@UlisesGascon will be the one promoting it. I will change the changelog name. |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
RafaelGSS
force-pushed
the
v20.19.1-proposal
branch
from
b25099a to
7d25553
Compare
aduh95
reviewed
Apr 16, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
RafaelGSS
force-pushed
the
v20.19.1-proposal
branch
from
7d25553 to
109a136
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Refs: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/ Refs: mozilla/sccache#2339 PR-URL: #57573 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Bumps [Mozilla-Actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.8 to 0.0.9. - [Release notes](https://github.com/mozilla-actions/sccache-action/releases) - [Commits](Mozilla-Actions/sccache-action@65101d4...7d986dd) --- updated-dependencies: - dependency-name: Mozilla-Actions/sccache-action dependency-version: 0.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #57720 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS
force-pushed
the
v20.19.1-proposal
branch
from
109a136 to
e7a6507
Compare
Collaborator
aduh95
approved these changes
Apr 18, 2025
Collaborator
UlisesGascon
approved these changes
Apr 20, 2025
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the great work @RafaelGSS!
Member
|
I will start with the promotion tomorrow in my morning (in aprox. 12h). |
Collaborator
Member
|
I am starting with the promotion now 🥳 📦 CI-Release: ci-release.nodejs.org/job/iojs+release/10915 |
Collaborator
UlisesGascon
pushed a commit
that referenced
this pull request
Apr 22, 2025
UlisesGascon
added a commit
to UlisesGascon/nodejs.org
that referenced
this pull request
Apr 22, 2025
5 tasks
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Apr 22, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025-04-22, Version 20.19.1 'Iron' (LTS), @UlisesGascon prepared by @RafaelGSS
Notable Changes
d5e73ce0f8] - deps: update undici to 6.21.2 (Matteo Collina) #57442e4a6323ab2] - deps: update c-ares to v1.34.5 (Node.js GitHub Bot) #57792Commits
d5e73ce0f8] - deps: update undici to 6.21.2 (Matteo Collina) #57442e4a6323ab2] - deps: update c-ares to v1.34.5 (Node.js GitHub Bot) #57792b2b9eb36af] - dns: restore dns query cache ttl (Ethan Arrowood) #5764007a99a5c0b] - doc: correct status of require(esm) warning in v20 changelog (Joyee Cheung) #57529d45517ccbf] - meta: bump Mozilla-Actions/sccache-action from 0.0.8 to 0.0.9 (dependabot[bot]) #57720fa93bb2633] - test: update parallel/test-tls-dhe for OpenSSL 3.5 (Richard Lau) #5747729c032403c] - tools: update sccache to support GH cache changes (Michaël Zasso) #57573