Closed
Conversation
mscdex
added
c++
Contributor
Author
|
Closing revert in favor of fix in #5786 |
3 tasks
Contributor
|
@evanlucas I am reopening this based on the comment by @ofrobots #5786 (comment) @nodejs/ctc do we want to merge this commit and cut a release today? |
Member
|
Friday releases suck :-( .. but given the breakage, +1 |
Contributor
|
@cjihrig I think this should be closed and targeted against v5.x specifically. thoughts? |
Contributor
|
As a note, we're closing in on weekend EU. If you want to do this, please be speedy about it. |
Contributor
Contributor
|
LGTM if Ci is green |
Contributor
|
closing once again for #5800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #5392
Refs: #5768
R= @ofrobots @evanlucas