fs: remove recursive option from rmdir

[LiviaMedeiros]

This moves DEP0147: fs.rmdir(path, { recursive: true }) to EOL.

The recursive option was runtime deprecated since v16.0.0 in favor of rm() function. Maybe it is time to remove it.

cc @nodejs/fs because fs Issues and PRs related to the fs subsystem / file system.
cc @nodejs/tsc because semver-major PRs that contain breaking changes and should be released in the next major version.
cc @addaleax because of concerns in the runtime deprecation PR #37302 (comment)

[mcollina]

lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (33f6e1e) to head (f9034bc).
Report is 559 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #57784    +/-   ##
========================================
  Coverage   90.24%   90.25%            
========================================
  Files         630      630            
  Lines      185245   185136   -109     
  Branches    36299    36286    -13     
========================================
- Hits       167173   167090    -83     
+ Misses      11018    10988    -30     
- Partials     7054     7058     +4     

Files with missing lines	Coverage Δ
lib/fs.js	98.25% <100.00%> (-0.02%)	⬇️
lib/internal/fs/promises.js	98.22% <ø> (-0.02%)	⬇️
lib/internal/fs/utils.js	99.68% <100.00%> (-0.01%)	⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66110/

CITGM:

• main https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3576/
• PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3577/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66172/

[mcollina]

There seem to be a lot of CITGM failures compared to main.

[LiviaMedeiros]

Closed in favour of #58616

[jasnell]

oh! I had completely missed this @LiviaMedeiros ! Sorry about that :-*(

[LiviaMedeiros]

No worries; as long as the change lands, am happy with it.