test: improve getCallSites

[jakecastelli]

dot-left supposed to be dot-right

The frame count is between 1 and 200. Testing 0.5 will be testing decimal fraction truncation to 0 which is still invalid range.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (af75d04) to head (640def1).
Report is 91 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57732      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185055   185197     +142     
  Branches    36221    36300      +79     
==========================================
+ Hits       166984   167140     +156     
+ Misses      11043    10988      -55     
- Partials     7028     7069      +41     

see 74 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66043/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66082/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/57732
✔  Done loading data for nodejs/node/pull/57732
----------------------------------- PR info ------------------------------------
Title      test: improve getCallSites (#57732)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     jakecastelli:add-lower-bound-range-test -> nodejs:main
Labels     test, author ready, needs-ci, commit-queue-rebase
Commits    2
 - test: fix the decimal fractions explaination
 - test: add test for frame count being 0.5
Committers 1
 - Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/57732
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57732
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 02 Apr 2025 15:00:26 GMT
   ✔  Approvals: 4
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57732#pullrequestreview-2740219853
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57732#pullrequestreview-2740921315
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57732#pullrequestreview-2742890295
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57732#pullrequestreview-2745191389
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-04-06T13:05:44Z: https://ci.nodejs.org/job/node-test-pull-request/66082/
- Querying data for job/node-test-pull-request/66082/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 57732
From https://github.com/nodejs/node
 * branch                  refs/pull/57732/merge -> FETCH_HEAD
✔  Fetched commits as a2de5b9150da..9f614ba63daf
--------------------------------------------------------------------------------
[main 130a6467ec] test: fix the decimal fractions explaination
 Author: Jake Yuesong Li <jake.yuesong@gmail.com>
 Date: Thu Apr 3 01:23:27 2025 +1030
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 85456ce8ef] test: add test for frame count being 0.5
 Author: Jake Yuesong Li <jake.yuesong@gmail.com>
 Date: Thu Apr 3 01:24:21 2025 +1030
 1 file changed, 5 insertions(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: fix the decimal fractions explaination
PR-URL: #57732

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Reviewed-By: James M Snell <jasnell@gmail.com>
[detached HEAD c929d4f321] test: fix the decimal fractions explaination

Author: Jake Yuesong Li <jake.yuesong@gmail.com>

Date: Thu Apr 3 01:23:27 2025 +1030

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: add test for frame count being 0.5
The frame count is between 1 and 200. Testing 0.5 will be testing decimal

fraction truncation to 0 which is still invalid range.
PR-URL: #57732

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Reviewed-By: James M Snell <jasnell@gmail.com>
[detached HEAD 682485d3c2] test: add test for frame count being 0.5

Author: Jake Yuesong Li <jake.yuesong@gmail.com>

Date: Thu Apr 3 01:24:21 2025 +1030

1 file changed, 5 insertions(+)

Successfully rebased and updated refs/heads/main.
✔  c929d4f3212c5545102e500317f142cbf2865de5

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

✖  682485d3c209ca8066d06de546a4749c6dd6d0d1

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✖  1:72     Line should be <= 72 columns.             line-length

✔  0:0      metadata is at end of message             metadata-end

✔  4:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue

https://github.com/nodejs/node/actions/runs/14299097568

[jakecastelli]

On a new laptop, haven't moved all the config files across, forgot to set textwidth=72 in my vim config, sorry!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66105/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66121/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66123/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66128/

flaky tests:
pummel.test-buffer-large-size
sequential.test-http2-large-file

[jakecastelli]

too many flaky tests 😅

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66138/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66151/

[nodejs-github-bot]

Landed in f3ba305...d4e9ae5