Skip to content

deps: update ada and web-platform tests#57693

Merged
aduh95 merged 2 commits intonodejs:mainfrom
anonrig:yagiz/update-url-ada
Apr 4, 2025
Merged

deps: update ada and web-platform tests#57693
aduh95 merged 2 commits intonodejs:mainfrom
anonrig:yagiz/update-url-ada

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Mar 30, 2025 •
edited
Loading

Updates Ada and url/urlpattern web-platform tests. Fixes several WPT thanks to @CarlosEduR. cc @nodejs/url

Fixes #57329

@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 30, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2025

Review requested:

  • @nodejs/security-wg
  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 30, 2025
@anonrig anonrig changed the title Yagiz/update url ada deps: update ada and web-platform tests Mar 30, 2025
@anonrig anonrig requested review from jasnell and mcollina March 30, 2025 17:43
@anonrig anonrig force-pushed the yagiz/update-url-ada branch from 397d906 to efda827 Compare March 30, 2025 17:44
@anonrig anonrig force-pushed the yagiz/update-url-ada branch from efda827 to faa6b6b Compare March 30, 2025 17:45
@anonrig anonrig requested a review from aduh95 March 30, 2025 17:45
@codecov
Copy link

codecov bot commented Mar 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (af75d04) to head (faa6b6b).
Report is 307 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57693      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         630      630              
  Lines      185055   185055              
  Branches    36221    36217       -4     
==========================================
- Hits       166984   166982       -2     
- Misses      11043    11045       +2     
  Partials     7028     7028

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 30, 2025
lpinca
lpinca reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65921/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65955/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65987/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2025
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2025
@aduh95 aduh95 merged commit 9de01cc into nodejs:main Apr 4, 2025
62 of 63 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Apr 4, 2025

Landed in 9de01cc

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@anonrig @JonasBa
deps: update ada to 3.2.2
95f9704 
PR-URL: nodejs#57693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@anonrig @RafaelGSS
deps: update ada to 3.2.2
dbfaca3 
PR-URL: #57693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@anonrig @RafaelGSS
deps: update ada to 3.2.2
ec29f56 
PR-URL: #57693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemire lemire lemire approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure opaque URL paths always roundtrip

7 participants

@anonrig @nodejs-github-bot @aduh95 @lemire @jasnell @lpinca @MoLow