Merged
Conversation
Member
Author
|
CC: @nodejs/build |
Contributor
|
Do the linting-related files really take up that much space though compared to the other things being removed in this PR? |
Member
Author
|
@mscdex 8% tarball size (9% xz). |
Member
|
Should this be labeled |
Member
Author
|
@ChALkeR because we're removing |
rvagg
added
the
semver-major
vcbuild.bat
Outdated
Member
There was a problem hiding this comment.
thinking you should probably be as nice here as you are in the Makefile about what's wrong
Member
|
semver-major is a good idea since it's a change in expectations for users building from source lgtm |
Makefile
Outdated
Contributor
|
LGTM. |
Member
|
LGTM with @bnoordhuis' comments addressed. |
This removes the ability to run linting from the source tarball, rationale being that developers should use a git clone instead. Also, fix the path of removing artifacts from the openssl dependency since it now lives in `deps/openssl/openssl/`. Tarballs shrink with ~10%. PR-URL: nodejs#5695 Fixes: nodejs#5618 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: thefourtheye <thechargingvolcano@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
jbergstroem
force-pushed
the
feature/slimmer-tarballs-v2
branch
from
c67846b to
90a5fc2
Compare
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
build, deps, tools
Description of change
Reduce the nodejs tarball size with another ~10% (it's grown pretty fast over the last year). The distinction we're making here is that developers should opt for git instead of tarballs, but the test suite should still be able to run (therefore verifying the generated binary). This means that stuff like linters or test suites in
deps/should go.