Merged
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
nodejs-github-bot
added
lib / src
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56624 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 665 665
Lines 192602 192602
Branches 37050 37060 +10
=======================================
+ Hits 171732 171743 +11
+ Misses 13678 13674 -4
+ Partials 7192 7185 -7 |
RafaelGSS
approved these changes
Jan 16, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Author
marco-ippolito
approved these changes
Jan 19, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Author
aduh95
added
the
author ready
nodejs-github-bot
changed the title
nodejs-github-bot
force-pushed
the
actions/tools-update-undici
branch
from
7f298c6 to
6ead0ab
Compare
UlisesGascon
approved these changes
Jan 26, 2025
targos
force-pushed
the
actions/tools-update-undici
branch
from
6ead0ab to
f22b440
Compare
Member
|
Rebased to fix the test failure. |
jasnell
approved these changes
Jan 29, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Author
nodejs-github-bot
force-pushed
the
actions/tools-update-undici
branch
from
f22b440 to
46eaec7
Compare
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/56624 ✔ Done loading data for nodejs/node/pull/56624 ----------------------------------- PR info ------------------------------------ Title deps: update undici to 7.3.0 (#56624) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-undici -> nodejs:main Labels lib / src, author ready, needs-ci, dependencies, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 1 - deps: update undici to 7.3.0 Committers 1 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/56624 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56624 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Jan 2025 09:29:39 GMT ✔ Approvals: 6 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2555930470 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2560935233 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2562848827 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56624#pullrequestreview-2574204741 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2581374721 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2589524963 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-29T15:16:59Z: https://ci.nodejs.org/job/node-test-pull-request/64822/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - deps: update undici to 7.3.0 - Querying data for job/node-test-pull-request/64822/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13111657431 |
Collaborator
Author
Collaborator
Author
Collaborator
Author
Collaborator
Author
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in 9dee7b9 |
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#56624 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of undici to 7.3.0.