[v22.x backport] permission: ignore internalModuleStat on module loading#56058
Merged
aduh95 merged 1 commit intonodejs:v22.x-stagingfrom Dec 10, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Nov 28, 2024
RafaelGSS
force-pushed
the
backport-55797-to-v22
branch
from
9261798 to
995d464
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
RafaelGSS
added
the
author ready
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: nodejs#55797 Backport-PR-URL: nodejs#56058 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95
force-pushed
the
backport-55797-to-v22
branch
from
995d464 to
aa6b0e8
Compare
Contributor
|
Landed in aa6b0e8 |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 5, 2025
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: #55797 Backport-PR-URL: #56058 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves Permission Model usage when allowing read access to specific modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check.
Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where
aattempt to load b, it will fails as it reads $pwd and no permission has been given to this path.PR-URL: #55797
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Ulises Gascón ulisesgascongonzalez@gmail.com