Closed
Conversation
This reverts commit d9f7a59. Changes here probably need wider discussion so revert the change until that can happen.
Trott
added
build
Contributor
|
Hmmm, this kinda goes back to my problem, though that flaky tests was fixed for me so I guess it's ok. |
Contributor
|
LGTM |
2 similar comments
Member
|
LGTM |
Contributor
|
LGTM |
Member
|
LETM! (E=Excellent) |
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2016
This reverts commit d9f7a59. Changes here probably need wider discussion so revert the change until that can happen. PR-URL: #5602 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
|
Landed in 89d5379 |
Member
Author
|
@Fishrock123 wrote:
I'll open a separate issue to list out options along with pros and cons so we can see if anything will work well enough to get consensus. |
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
This reverts commit d9f7a59. Changes here probably need wider discussion so revert the change until that can happen. PR-URL: #5602 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
This reverts commit d9f7a59. Changes here probably need wider discussion so revert the change until that can happen. PR-URL: #5602 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
since the original commit never landed I'm labeling this dont land for LTS. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
The reverted commit seems to have been mildly controversial. Revert it for now. If the change or something similar is highly desirable, a wider conversation can happen.
/cc @bnoordhuis @jbergstroem @evanlucas @Fishrock123 @jasnell @thealphanerd