src: fix argv memory leaking in FixupArgsForSEA#55579
Open
CGQAQ wants to merge 3 commits intonodejs:mainfrom
Open
src: fix argv memory leaking in FixupArgsForSEA#55579CGQAQ wants to merge 3 commits intonodejs:mainfrom
CGQAQ wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55579 +/- ##
==========================================
+ Coverage 88.36% 88.43% +0.07%
==========================================
Files 652 654 +2
Lines 187245 187731 +486
Branches 35990 36137 +147
==========================================
+ Hits 165451 166018 +567
+ Misses 15074 14953 -121
- Partials 6720 6760 +40
🚀 New features to boost your workflow:
|
178ae6b to
21951c6
Compare
joyeecheung
reviewed
Oct 30, 2024
jasnell
approved these changes
Nov 5, 2024
joyeecheung
approved these changes
Dec 23, 2025
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was allocated here