test_runner: mark mockTimers as stable by ErickWendel · Pull Request #55398 · nodejs/node

ErickWendel · 2024-10-15T21:17:02Z

The MockTimers feature was introduced back in April 2023 on #47775 and had been receiving several fixes and improvements since then, currently there're no open issues.

nodejs-github-bot · 2024-10-15T21:17:06Z

Review requested:

@nodejs/test_runner

codecov · 2024-10-15T22:36:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (2545b9e) to head (613f3cc).
Report is 283 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55398      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.01%     
==========================================
  Files         652      652              
  Lines      186914   186911       -3     
  Branches    36077    36069       -8     
==========================================
- Hits       165277   165266      -11     
- Misses      14889    14897       +8     
  Partials     6748     6748

Files with missing lines	Coverage Δ
lib/internal/test_runner/mock/mock_timers.js	`98.73% <ø> (-0.02%)`	⬇️

... and 38 files with indirect coverage changes

doc/api/test.md

nodejs-github-bot · 2024-10-16T00:34:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63131/

mcollina

lgtm

nodejs-github-bot · 2024-10-16T07:29:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63135/

Signed-off-by: Erick Wendel <erick.workspace@gmail.com>

nodejs-github-bot · 2024-10-17T12:10:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63160/

nodejs-github-bot · 2024-10-17T21:24:43Z

Landed in 142e405...0c68991

PR-URL: #55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

PR-URL: #55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

github-actions · 2024-10-19T14:51:27Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @ErickWendel.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

ErickWendel · 2024-10-19T14:55:08Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @ErickWendel.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

MockTimers, introduced in April 2023, has just reached stable status. This API provides comprehensive support for mocking Dates and all major timers in Node.js, including setTimeout, setInterval, and setImmediate, both from the node:timers, node:timers/promises modules and global objects. After months of refinement, developers can now fully rely on MockTimers for testing time-based operations with confidence, ensuring better control over asynchronous behavior in their Node.js applications.

atlowChemi · 2024-10-21T17:33:14Z

@ErickWendel I think we should also mention node:timers/promises as well, WDYT?

ErickWendel · 2024-10-21T18:47:29Z

@ErickWendel I think we should also mention node:timers/promises as well, WDYT?

yes indeed! Just updated it! wdyt?

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: #55513

PR-URL: nodejs#55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs#55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) nodejs#55398 PR-URL: nodejs#55513

PR-URL: nodejs#55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs#55398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) nodejs#55398 PR-URL: nodejs#55513

ruyadorno · 2024-11-27T06:37:59Z

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

test_runner: mark mockTimers as stable

248fe80

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 15, 2024

cjihrig approved these changes Oct 15, 2024

View reviewed changes

avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 16, 2024

avivkeller reviewed Oct 16, 2024

View reviewed changes

doc/api/test.md Show resolved Hide resolved

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024

marco-ippolito approved these changes Oct 16, 2024

View reviewed changes

mcollina approved these changes Oct 16, 2024

View reviewed changes

MoLow approved these changes Oct 16, 2024

View reviewed changes

doc: add changelog for mocktimers

613f3cc

Signed-off-by: Erick Wendel <erick.workspace@gmail.com>

ErickWendel requested a review from avivkeller October 16, 2024 14:17

jakecastelli approved these changes Oct 17, 2024

View reviewed changes

jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024

ErickWendel added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2024

benjamingr added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 17, 2024

atlowChemi approved these changes Oct 17, 2024

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2024

nodejs-github-bot closed this Oct 17, 2024

ErickWendel added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 19, 2024

aduh95 mentioned this pull request Oct 24, 2024

V23.1.0 proposal #55513

Merged

ruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024

Uh oh!

Conversation

ErickWendel commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 15, 2024

Uh oh!

codecov bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 16, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 16, 2024

Uh oh!

nodejs-github-bot commented Oct 17, 2024

Uh oh!

nodejs-github-bot commented Oct 17, 2024

Uh oh!

github-actions bot commented Oct 19, 2024

Uh oh!

ErickWendel commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atlowChemi commented Oct 21, 2024

Uh oh!

ErickWendel commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ruyadorno commented Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ErickWendel commented Oct 15, 2024 •

edited

Loading

codecov bot commented Oct 15, 2024 •

edited

Loading

ErickWendel commented Oct 19, 2024 •

edited

Loading

ErickWendel commented Oct 21, 2024 •

edited

Loading